test: remove duplicate keys from bulk response fixtures - #190
Merged
kenhys merged 1 commit intoSep 11, 2026
Merged
Conversation
json 3.0 raises JSON::ParserError for duplicate keys in a JSON object, so these fixtures fail to parse depending on which adapter MultiJson picks. The repeated "_type" and "_id" entries carry the same value and were not covering duplicate key handling, so drop them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
kenhys
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json 3.0 raises
JSON::ParserErrorfor duplicate keys in a JSON object, so two bulk response fixtures fail to parse and CI is red onmainas well.The repeated
"_type"and"_id"entries carry the same value and were not covering duplicate key handling, so they are dropped instead of relaxing the parser in the tests.PR #185 covered
lib/fluent/plugin/opensearch_index_template.rb, but the test fixtures were left as they were.🤖 Generated with Claude Code