Conversation
Before: `hosts` accepts "https://user:password@host" and `endpoint.url` can carry a user and a password, but neither was marked secret. Fluentd logs the whole configuration after configure and masks only secret parameters, so those passwords were written to the log in plain text. After: `hosts` in both plugins and `endpoint.url` are secret, so the dump shows "xxxxxx" for them. The host list no longer appears in the startup log. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
hostsaccepts "https://user:password@host" andendpoint.urlcan carry a user and a password, but neither was marked secret. Fluentd logs the whole configuration after configure and masks only secret parameters, so those passwords were written to the log in plain text.After:
hostsin both plugins andendpoint.urlare secret, so the dump shows "xxxxxx" for them. The host list no longer appears in the startup log.