Conversation
Before: client() cleared the shared @_os slot and then rebuilt it with `||=`, without a lock. With flush_thread_count of 2 or more and a host placeholder, a thread could pass the "is this the same host" check and then pick up the client another thread had just built for a different host, so its chunk went to that cluster instead. After: the whole check-and-build runs under a mutex, so a thread always gets a client for the host it asked for. The mutex is created in initialize because configure builds a client before it returns. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Contributor
|
@kenhys This type of fix also ought to apply for https://github.com/uken/fluent-plugin-elasticsearch? |
Contributor
Author
I've overlooked it, maybe similar fix is needed. |
kenhys
marked this pull request as ready for review
September 17, 2026 01:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: client() cleared the shared @_os slot and then rebuilt it with
||=, without a lock. With flush_thread_count of 2 or more and a host placeholder, a thread could pass the "is this the same host" check and then pick up the client another thread had just built for a different host, so its chunk went to that cluster instead.After: the whole check-and-build runs under a mutex, so a thread always gets a client for the host it asked for. The mutex is created in initialize because configure builds a client before it returns.