Make nokogiri optional#40
Merged
Merged
Conversation
ashie
commented
Jun 18, 2026
ashie
force-pushed
the
rexml
branch
9 times, most recently
from
82c54b2 to
e523e7b
Compare
Member
Author
|
It should bump up minor or major version, so shouldn't bundle in fluent-package 6.0. |
kenhys
approved these changes
Jun 22, 2026
Watson1978
reviewed
Jun 22, 2026
Watson1978
reviewed
Jun 22, 2026
Watson1978
reviewed
Jun 22, 2026
Watson1978
reviewed
Jun 22, 2026
Watson1978
requested changes
Jun 22, 2026
Watson1978
left a comment
Watson1978
left a comment
Contributor
There was a problem hiding this comment.
initialize method must call super
Use REXML as runtime fallback. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Merged
Watson1978
pushed a commit
that referenced
this pull request
Jul 1, 2026
* Make nokogiri optional (#40) Signed-off-by: Takuro Ashie <ashie@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use REXML as runtime fallback.
We are considering to drop Nokogiri from fluent-package in the next major version.
AFAIK only this plugin mandatory depends on Nokogiri in the package.
Probably this plugin isn't so used recent days since windows_eventlog2 plugin doesn't use XML output by default in current version. We will deprecate XML output, so we don't care about performance degradation by replacing nokogiri with REXML. If a user is concerned about this, we will prompt them to install Nokogiri themselves.