Skip to content

test_fluentd: read until EOF in assert_fluentd_fails_to_start #5447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Watson1978 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test_fluentd: read until EOF in assert_fluentd_fails_to_start #5447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions test/command/test_fluentd.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,10 +230,15 @@ def assert_fluentd_fails_to_start(cmdline, *pattern_list, timeout: 20)
execute_command(cmdline) do |pid, stdout|
begin
waiting(timeout) do
while process_exist?(pid) && !running
# Read until EOF (the write-end of the pipe is closed when the
# process exits) so that we don't miss the final error message.
# Gating the loop on `process_exist?(pid)` is racy: the process can
# write its last line and exit right after `eager_read`, leaving
# that line unread in the pipe buffer.
until running
readables, _, _ = IO.select([stdout], nil, nil, 1)
next unless readables
next if readables.first.eof?
break if readables.first.eof?

stdio_buf << eager_read(readables.first)
lines = stdio_buf.split("\n")
Expand Down