fix(alluxio): propagate shared flag for direct UFS mounts#5526
fix(alluxio): propagate shared flag for direct UFS mounts#5526mrhapile wants to merge 1 commit intofluid-cloudnative:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @mrhapile, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an inconsistency in how the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Hi @mrhapile. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request effectively resolves the issue where the shared: true flag was not propagated for direct UFS mounts in Alluxio. By introducing a conditional check for m.Shared and setting the alluxio.master.mount.table.root.shared property, the change ensures consistent behavior across different mount modes. This is a targeted and correct fix for the described problem.
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the shared: true flag specified in Dataset mounts was being ignored for direct UFS mounts in Alluxio. The fix ensures that when a single mount with shared: true is configured as the root mount, the property alluxio.master.mount.table.root.shared=true is properly set in Alluxio's configuration.
Changes:
- Added propagation of the
sharedflag to Alluxio mount table properties for direct UFS root mounts - Makes direct UFS mount behavior consistent with ConfigMap-based mount logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5526 +/- ##
==========================================
- Coverage 57.66% 57.65% -0.01%
==========================================
Files 444 444
Lines 30424 30427 +3
==========================================
Hits 17544 17544
- Misses 11406 11409 +3
Partials 1474 1474 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: mrhapile <allinonegaming3456@gmail.com>
mrhapile
force-pushed
the
fix/dataset-shared-mount-998
branch
from
073126f to
c783ad7
Compare
|
|
@RongGu can you review this |
1 participant
Ⅰ. Describe what this PR does
This PR fixes an issue where
shared: truespecified in Dataset mounts was ignored fordirect UFS mounts in Alluxio.
Previously, the
sharedflag was only respected when mounts were generated viaConfigMap-based mounting. For direct UFS mounts generated in
pkg/ddc/alluxio/transform.go, the shared option was not propagated, causing Alluxioto always report mounts as
not shared.This change propagates the shared flag to Alluxio mount table properties by setting
alluxio.master.mount.table.root.shared=truewhen the root mount is marked as shared,making the behavior consistent across different mount modes.
Ⅱ. Does this pull request fix one issue?
fixes #998
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
No new tests were added.
This change is a minimal configuration propagation fix that aligns direct UFS mount
behavior with existing ConfigMap-based mount logic. The correctness can be verified
via runtime inspection of Alluxio mount status and configuration, and adding unit
tests would require significant mocking of runtime behavior.
Ⅳ. Describe how to verify it
shared: true.