[video_player_avplay] Fix the issue where seeking the beginning of the live DASH manifest fails.#967
Open
gin7773 wants to merge 2 commits intoflutter-tizen:masterfrom
Open
[video_player_avplay] Fix the issue where seeking the beginning of the live DASH manifest fails.#967gin7773 wants to merge 2 commits intoflutter-tizen:masterfrom
gin7773 wants to merge 2 commits intoflutter-tizen:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increments the package version to 0.8.6 in pubspec.yaml, README.md, and CHANGELOG.md. The changelog is updated to reflect the fix for an issue where seeking to the beginning of a live DASH manifest would fail. I have provided one suggestion to improve the formatting of the changelog entry for better clarity and conciseness.
Comment on lines
+3
to
+4
| * Update plusplayer | ||
| 1. [DASH] Fix the issue where seeking the beginning of the live DASH manifest fails. |
There was a problem hiding this comment.
For conciseness and better readability, consider combining these two lines into a single bullet point. Using a numbered list for a single item is a bit unconventional.
Suggested change
| * Update plusplayer | |
| 1. [DASH] Fix the issue where seeking the beginning of the live DASH manifest fails. | |
| * Updated `plusplayer` to fix an issue where seeking to the beginning of a live DASH manifest would fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes: