Separate binding code into individual module-specific bindings#60
Open
seungsoo47 wants to merge 12 commits intoflutter-tizen:mainfrom
Open
Separate binding code into individual module-specific bindings#60seungsoo47 wants to merge 12 commits intoflutter-tizen:mainfrom
seungsoo47 wants to merge 12 commits intoflutter-tizen:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a significant refactoring to modularize the FFI bindings, which greatly improves maintainability. The changes in the integration tests correctly reflect this new modular structure. I've found one minor issue in the test logic for error handling which should be addressed.
- Merge entrypoints-*.h files to one entrypoints.h. - Fix bugs where library files were missing from the scripts/symgen_helper.sh script output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is a refactoring effort to modularize the tizen_interop binding structure, improving code management and maintainability.