Skip to content

Hide extension button when embedded in an IDE - #9956

Open
johnpryan wants to merge 11 commits into
flutter:masterfrom
johnpryan:fix-8507
Open

Hide extension button when embedded in an IDE#9956
johnpryan wants to merge 11 commits into
flutter:masterfrom
johnpryan:fix-8507

Conversation

@johnpryan

@johnpryan johnpryan commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Hide the extension settings action when DevTools is running in an IDE, unless the current screen is an extension.

This also helps with debugging extensions locally by adding an agent skill, and by fixing an issue where flutter.dev's X-Frame-Options header caused a "connection refused" when debugging extensions locally.

Fixes #8507

@johnpryan
johnpryan requested a review from a team as a code owner August 10, 2026 23:46
@johnpryan
johnpryan requested review from bkonyi and removed request for a team August 10, 2026 23:46

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the DevTools scaffold to conditionally show or hide the ExtensionSettingsAction based on the current screen and the embed mode. Specifically, when DevTools is embedded in an IDE (EmbedMode.embedOne), the extension settings action is hidden unless the active screen is an ExtensionScreen or the query parameters specify to hide all except extensions. The changes also include corresponding updates to the status line and comprehensive unit and widget tests to verify this behavior. There are no review comments, and I have no feedback to provide.

_controller_web.dart to prevent browser X-Frame-Options
iframe errors during local debugging.
@johnpryan
johnpryan requested review from kenzieschmoll and removed request for bkonyi August 11, 2026 16:21
Comment thread packages/devtools_app/lib/src/extensions/embedded/_controller_web.dart Outdated
Comment thread .agents/skills/debugging-devtools-extensions/SKILL.md Outdated
Comment thread .agents/skills/debugging-devtools-extensions/SKILL.md Outdated
Comment thread .agents/skills/debugging-devtools-extensions/SKILL.md Outdated
Comment thread .agents/skills/debugging-devtools-extensions/SKILL.md Outdated
When an AI agent is performing this workflow:

- **Obtaining VM Service URI**: When connecting to a target app, ask the user to provide the VM Service URI printed in the target app's console output (using `ask_question` or a direct prompt).
- **Automated Browser Opening**: The agent should launch DevTools and execute `open <url>` to launch the browser automatically.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

step 2B above gives other commands depending on the OS. Should we include those other commands here or link to where this is described above?

Comment thread .agents/skills/debugging-devtools-extensions/SKILL.md Outdated
@johnpryan

Copy link
Copy Markdown
Contributor Author

@kenzieschmoll this is ready for another look

Comment thread packages/devtools_app/lib/src/framework/scaffold/scaffold.dart Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DevTools extensions menu button does not need to show when in embed mode embedOne

3 participants