Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 3.24.0

* Adds support for `javaScriptCanOpenWindowsAutomatically` to allow JavaScript's
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uber nit: maybe
WebKitWebViewControllerCreationParams.javaScriptCanOpenWindowsAutomatically so the reader doesn't have to look for the exact name space.

`window.open()` to work without user interaction on iOS and macOS.

## 3.23.5

* Removes internal native library Dart proxy.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,16 @@ class PreferencesProxyAPITests: XCTestCase {
XCTAssertEqual(instance.javaScriptEnabled, enabled)
}
}

@MainActor func testSetJavaScriptCanOpenWindowsAutomatically() throws {
let registrar = TestProxyApiRegistrar()
let api = registrar.apiDelegate.pigeonApiWKPreferences(registrar)

let instance = WKPreferences()
let enabled = true
try api.pigeonDelegate.setJavaScriptCanOpenWindowsAutomatically(
pigeonApi: api, pigeonInstance: instance, enabled: enabled)

XCTAssertEqual(instance.javaScriptCanOpenWindowsAutomatically, enabled)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,10 @@ class PreferencesProxyAPIDelegate: PigeonApiDelegateWKPreferences {
pigeonInstance.javaScriptEnabled = enabled
}
}

func setJavaScriptCanOpenWindowsAutomatically(
pigeonApi: PigeonApiWKPreferences, pigeonInstance: WKPreferences, enabled: Bool
) throws {
pigeonInstance.javaScriptCanOpenWindowsAutomatically = enabled
}
}

Large diffs are not rendered by default.

Loading