Skip to content

[google_maps_flutter] Remove .static from Package.swift#11392

Open
stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
stuartmorgan-g:maps-ios-remove-static
Open

[google_maps_flutter] Remove .static from Package.swift#11392
stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
stuartmorgan-g:maps-ios-remove-static

Conversation

@stuartmorgan-g
Copy link
Copy Markdown
Collaborator

The Swift Package Manager spec was requiring static builds, rather than following the Apple suggestion of letting the build process determine the build mode. This was a carryover from the CocoaPods spec, but based on commit history that was only to address some unspecified compatibility issue with Swift apps, long ago (before module builds were standard, for example).

We are not aware of any reason for this setting that applies to Package.swift, so we should remove it absent new evidence that it is necessary. (Arguably we could remove it from the CP spec too, but since that's a legacy mode anyway, it's probably best to leave it as is to avoid any potential disruptions in edge cases we aren't aware of.)

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

The Swift Package Manager spec was requiring static builds, rather than
following the Apple suggestion of letting the build process determine
the build mode. This was a carryover from the CocoaPods spec, but based
on commit history that was only to address some unspecified
compatibility issue with Swift apps, long ago (before module builds were
standard, for example).

We are not aware of any reason for this setting that applies to
Package.swift, so we should remove it absent new evidence that it is
necessary. (Arguably we could remove it from the CP spec too, but since
that's a legacy mode anyway, it's probably best to leave it as is to
avoid any potential disruptions in edge cases we aren't aware of.)
@flutter-dashboard
Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan-g
Copy link
Copy Markdown
Collaborator Author

test-exempt: configuration change

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates google_maps_flutter_ios_sdk10 and google_maps_flutter_ios_sdk9 to version 2.18.1, removing the requirement for static builds when using Swift Package Manager. Feedback suggests reverting the formatting of the library definitions in Package.swift files to multi-line to improve readability and adhere to line length limits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant