[ci] refactor: Cleanup tooling for handling arch build output <= Flutter v3.13.x#11399
[ci] refactor: Cleanup tooling for handling arch build output <= Flutter v3.13.x#11399Gustl22 wants to merge 2 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates the Pigeon test runner and the repository's native test tool to utilize dart:ffi's Abi for architecture detection, adding support for Linux RISC-V and ARM64. It also refactors CMakeProject to require an architecture and removes legacy compatibility logic for older Flutter versions. Feedback was provided regarding the architecture detection logic in native_test_command.dart, suggesting an explicit mapping to avoid fragile assumptions when handling multiple architectures.
|
I suspect its test-exempt: Remove code without adding functionality. |
There remained some code, which was left in to support build output for Flutter <= v3.13.x.
As the minimum supported Flutter version is 3.35.x as of
packages/.ci/targets/repo_checks.yaml
Line 31 in eab1265
we can remove it now.
Contributes to flutter/flutter#129807
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2