Skip to content

[ci] refactor: Cleanup tooling for handling arch build output <= Flutter v3.13.x#11399

Open
Gustl22 wants to merge 2 commits intoflutter:mainfrom
Gustl22:129807-cleanup-tooling-arch
Open

[ci] refactor: Cleanup tooling for handling arch build output <= Flutter v3.13.x#11399
Gustl22 wants to merge 2 commits intoflutter:mainfrom
Gustl22:129807-cleanup-tooling-arch

Conversation

@Gustl22
Copy link
Copy Markdown
Contributor

@Gustl22 Gustl22 commented Mar 30, 2026

There remained some code, which was left in to support build output for Flutter <= v3.13.x.
As the minimum supported Flutter version is 3.35.x as of

- "--min-min-flutter-version=3.35.0"

we can remove it now.

Contributes to flutter/flutter#129807

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard
Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Pigeon test runner and the repository's native test tool to utilize dart:ffi's Abi for architecture detection, adding support for Linux RISC-V and ARM64. It also refactors CMakeProject to require an architecture and removes legacy compatibility logic for older Flutter versions. Feedback was provided regarding the architecture detection logic in native_test_command.dart, suggesting an explicit mapping to avoid fragile assumptions when handling multiple architectures.

@Gustl22
Copy link
Copy Markdown
Contributor Author

Gustl22 commented Mar 31, 2026

I suspect its

test-exempt: Remove code without adding functionality.

@stuartmorgan-g stuartmorgan-g self-requested a review March 31, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant