[pigeon] Support lists-and-maps of lists-and-maps#11400
[pigeon] Support lists-and-maps of lists-and-maps#11400srawlins wants to merge 3 commits intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Pigeon Dart generator to support nested List and Map types by implementing a recursive casting mechanism. It adds nested collection fields such as boolListList, boolMapList, and boolListMap to the core test pigeons and introduces a new echoNonNullBoolListList method to the host integration API. The changes encompass updates to generated code across all supported platforms and the addition of integration tests. Feedback indicates that the objectVersion in the macOS Xcode project file was downgraded, which appears to be an unintentional change that should be reverted.
packages/pigeon/platform_tests/test_plugin/example/macos/Runner.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
tarrinneal
left a comment
There was a problem hiding this comment.
Can you add a 6 layer dip version of this into the tests? assuming it works with more layers than 2. (I haven't had a chance to look too hard)
| repository: https://github.com/flutter/packages/tree/main/packages/pigeon | ||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+pigeon%22 | ||
| version: 26.3.3 # This must match the version in lib/src/generator_tools.dart | ||
| version: 26.3.4 # This must match the version in lib/src/generator_tools.dart |
There was a problem hiding this comment.
should probably be 26.4.0
|
Haha I could! It probably doesn't generate a bonkers amount of code. I'll try for 5-ish layers. (Hopefully a very unrealistic test case, but maybe not.) |
Fixes flutter/flutter#116117
This PR is massive because of the added test data. 😬 But the source changes, in
lib/src/dart/dart_generator.dart, are pretty minimal.Please let me know if I added too many new test data, or if I need more.
The strategy is summed up in the doc comment to the
_castCallmethod:type, likeList<int>, the returned code is a simple call toList.cast:cast<int>().List<List<int>>, the returned code usesList.mapandList.cast:map((e) => (e! as List<Object?>).cast<int>()).toList().Map<int, List<int>>, the returned code usesMap.mapandMap.cast:map((k, v) => MapEntry(k! as int, (v! as List<Object?>).cast<int>())).Pre-Review Checklist
[shared_preferences]///).