Skip to content

Add circular reference tests to unpatched branch #11742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jeffkwoh wants to merge 1 commit into
base: main
Choose a base branch
from
+154 −0
Draft

Add circular reference tests to unpatched branch #11742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
154 changes: 154 additions & 0 deletions packages/vector_graphics_compiler/test/parser_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,160 @@ class _TestOpacityColorMapper implements ColorMapper {
}

void main() {
test('Circular Mask Loop Avoidance', () {
final VectorInstructions instructions = parseWithoutOptimizers('''
<svg viewBox="0 0 100 100">
<mask id="mask1">
<g mask="url(#mask1)">
<rect width="100" height="100" fill="white"/>
</g>
</mask>
<rect width="100" height="100" fill="blue" mask="url(#mask1)"/>
</svg>
''');

expect(instructions.paths.isNotEmpty, true);
});

test('Unreferenced Circular Mask Loop resolves successfully', () {
final VectorInstructions instructions = parseWithoutOptimizers('''
<svg viewBox="0 0 100 100">
<defs>
<mask id="mask1">
<g mask="url(#mask2)">
<rect width="100" height="100" fill="white"/>
</g>
</mask>
<mask id="mask2">
<g mask="url(#mask1)">
<rect width="100" height="100" fill="white"/>
</g>
</mask>
</defs>
<rect width="10" height="10" fill="red" />
</svg>
''');

expect(instructions.paths.length, 1);
});

test('Multi-hop Referenced Circular Mask Loop Avoidance', () {
final VectorInstructions instructions = parseWithoutOptimizers('''
<svg viewBox="0 0 100 100">
<defs>
<mask id="mask1">
<g mask="url(#mask2)">
<rect width="100" height="100" fill="white"/>
</g>
</mask>
<mask id="mask2">
<g mask="url(#mask3)">
<rect width="100" height="100" fill="white"/>
</g>
</mask>
<mask id="mask3">
<g mask="url(#mask1)">
<rect width="100" height="100" fill="white"/>
</g>
</mask>
</defs>
<rect width="100" height="100" fill="blue" mask="url(#mask1)"/>
</svg>
''');

expect(instructions.paths.isNotEmpty, true);
});

test('Circular Deferred Node Loop Avoidance', () {
final VectorInstructions instructions = parseWithoutOptimizers('''
<svg viewBox="0 0 100 100">
<g id="groupA">
<use xlink:href="#groupB" />
</g>
<g id="groupB">
<use xlink:href="#groupA" />
</g>
<use xlink:href="#groupA" />
</svg>
''');

expect(instructions.paths.isEmpty, true);
});

test('Unreferenced Circular Use Loop resolves successfully', () {
final VectorInstructions instructions = parseWithoutOptimizers('''
<svg viewBox="0 0 100 100">
<defs>
<g id="groupA">
<use xlink:href="#groupB" />
</g>
<g id="groupB">
<use xlink:href="#groupA" />
</g>
</defs>
<rect width="10" height="10" fill="red" />
</svg>
''');

expect(instructions.paths.length, 1);
});

test('Multi-hop Referenced Circular Use Loop Avoidance', () {
final VectorInstructions instructions = parseWithoutOptimizers('''
<svg viewBox="0 0 100 100">
<defs>
<g id="groupA">
<use xlink:href="#groupB" />
</g>
<g id="groupB">
<use xlink:href="#groupC" />
</g>
<g id="groupC">
<use xlink:href="#groupA" />
</g>
</defs>
<use xlink:href="#groupA" />
</svg>
''');

expect(instructions.paths.isEmpty, true);
});

test('Circular Pattern Loop Avoidance', () {
final VectorInstructions instructions = parseWithoutOptimizers('''
<svg viewBox="0 0 100 100">
<pattern id="pattern1" width="20" height="20" patternUnits="userSpaceOnUse">
<rect width="20" height="20" fill="url(#pattern1)"/>
</pattern>
<rect width="100" height="100" fill="url(#pattern1)"/>
</svg>
''');

expect(instructions.paths.isNotEmpty, true);
});

test('Circular ClipPath Loop Avoidance', () {
final VectorInstructions instructions = parseWithoutOptimizers('''
<svg viewBox="0 0 100 100">
<g id="groupA">
<use xlink:href="#groupB" />
</g>
<g id="groupB">
<use xlink:href="#groupA" />
</g>
<clipPath id="clip1">
<use xlink:href="#groupA" />
</clipPath>
<rect width="100" height="100" fill="blue" clip-path="url(#clip1)"/>
</svg>
''');
expect(instructions.paths.length, 1);
expect(
instructions.commands.any((c) => c.type == DrawCommandType.clip),
false,
);
});

test('Reuse ID self-referentially', () {
final VectorInstructions instructions = parseWithoutOptimizers('''
<?xml version="1.0" encoding="UTF-8"?>
Expand Down