Skip to content

[google_maps_flutter] Add a pinned-SDK web example app#11761

Open
stuartmorgan-g wants to merge 9 commits into
flutter:mainfrom
stuartmorgan-g:maps-heatmap-test-app
Open

[google_maps_flutter] Add a pinned-SDK web example app#11761
stuartmorgan-g wants to merge 9 commits into
flutter:mainfrom
stuartmorgan-g:maps-heatmap-test-app

Conversation

@stuartmorgan-g
Copy link
Copy Markdown
Collaborator

The tree is currently closed because Google Maps SDK 3.65 came out, and it throws exceptions why trying to use heatmaps, as that functionality has been removed from the SDK.

This fixes the tree by creating a second example app for google_maps_flutter_web that pins version 3.64 of the Google Maps SDK:

  • copied the original example
  • removed all of the non-heatmap tests
  • consolidated the tests into one file (since it's not clear to me why we had two almost identically-named tests in the firs place, and it was especially confusing with just a few tests)

The heatmap tests have been removed from the main example, where they throw.

The README has been updated to explain that heatmaps are deprecated, and using them requires pinning 3.64.

Fixes flutter/flutter#186946

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the google_maps_flutter_web package to address the removal of heatmap support in version 3.65 of the Google Maps JavaScript SDK. Key changes include updating the README with deprecation notices and instructions for pinning the SDK to version 3.64, as well as restructuring the example apps into latest and 3-64 directories. Heatmap integration tests have been moved to the pinned 3-64 example. Review feedback includes corrections for a typo in the documentation, fixing inaccurate comments in the test files, and removing unused dependencies in the new example's configuration.

Comment thread packages/google_maps_flutter/google_maps_flutter_web/README.md Outdated
Comment thread packages/google_maps_flutter/google_maps_flutter_web/example/3-64/pubspec.yaml Outdated
@github-actions github-actions Bot removed the CICD Run CI/CD label May 22, 2026
@stuartmorgan-g stuartmorgan-g added the CICD Run CI/CD label May 22, 2026
@stuartmorgan-g
Copy link
Copy Markdown
Collaborator Author

@bparrishMines @tarrinneal If either of you have a chance to review this before @mdebbar please take a look, since it will let us re-open the tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[packages] Tree closed on heatmap removal

1 participant