[material_ui] Remove unused parameters from constructors of generic classes. - #12458
Open
srawlins wants to merge 1 commit into
Open
[material_ui] Remove unused parameters from constructors of generic classes.#12458srawlins wants to merge 1 commit into
srawlins wants to merge 1 commit into
Conversation
…lasses. We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes. This is work towards dart-lang/sdk#47839.
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes unused super.key parameters from several private widget constructors across the material_ui package, including _AutocompleteOptions, _ModalBottomSheet, _DropdownMenuItemButton, _DropdownMenu, _DropdownRoutePage, _MenuItem, _PopupMenu, and _SegmentedButtonRenderWidget. Additionally, it removes the menuWidth and underline parameters from certain dropdown constructors, initializing them to null directly, and simplifies the _CustomPageRoute constructor in tests. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes.
This is work towards dart-lang/sdk#47839.
Pre-Review Checklist
[shared_preferences]///).Test exempt, as this code is covered by existing static and runtime checks.