Skip to content

[material_ui] Remove unused parameters from constructors of generic classes. - #12458

Open
srawlins wants to merge 1 commit into
flutter:mainfrom
srawlins:unused-generic-mat
Open

[material_ui] Remove unused parameters from constructors of generic classes.#12458
srawlins wants to merge 1 commit into
flutter:mainfrom
srawlins:unused-generic-mat

Conversation

@srawlins

Copy link
Copy Markdown
Contributor

We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes.

This is work towards dart-lang/sdk#47839.

Pre-Review Checklist

Test exempt, as this code is covered by existing static and runtime checks.

…lasses.

We already don't allow unused parameters from non-generic classes. There was a
bug preventing us from reporting such parameters on generic classes.

This is work towards dart-lang/sdk#47839.
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 13, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Aug 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes unused super.key parameters from several private widget constructors across the material_ui package, including _AutocompleteOptions, _ModalBottomSheet, _DropdownMenuItemButton, _DropdownMenu, _DropdownRoutePage, _MenuItem, _PopupMenu, and _SegmentedButtonRenderWidget. Additionally, it removes the menuWidth and underline parameters from certain dropdown constructors, initializing them to null directly, and simplifies the _CustomPageRoute constructor in tests. There are no review comments, and I have no feedback to provide.

@Piinks Piinks added triage-design Should be looked at in design triage and removed triage-framework Should be looked at in framework triage labels Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants