Skip to content

[animations] Migrate to material_ui - #12467

Open
Piinks wants to merge 3 commits into
flutter:mainfrom
Piinks:migrate-Animations
Open

[animations] Migrate to material_ui#12467
Piinks wants to merge 3 commits into
flutter:mainfrom
Piinks:migrate-Animations

Conversation

@Piinks

@Piinks Piinks commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Migrates the animations package to the material_ui package.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 13, 2026
@github-actions github-actions Bot added p: animations triage-framework Should be looked at in framework triage labels Aug 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the animations package, its examples, and tests to use an external material_ui package instead of Flutter's standard material library, bumping the package version to 3.0.0. Feedback indicates that as a core Flutter package, animations must rely on the built-in material library, and the external dependency and import changes should be reverted.

Comment thread packages/animations/pubspec.yaml
Comment thread packages/animations/lib/src/fade_scale_transition.dart
Comment thread packages/animations/example/pubspec.yaml
Comment thread packages/animations/pubspec.yaml
Comment thread packages/animations/pubspec.yaml Outdated
Comment thread packages/animations/example/lib/main.dart Outdated
required this.transitionDuration,
required this.reverseTransitionDuration,
required _ModalTransitionBuilder transitionBuilder,
required this._transitionBuilder,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change due to newly firing prefer_initializing_formals with Dart 3.12

@Piinks

Piinks commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

CI was a timeout, re-running

@Piinks
Piinks requested a review from stuartmorgan-g August 17, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: animations triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants