[material_ui] Port flutter/flutter #190206 "Prevent stale async suggestions in SearchAnchor" - #12478
Open
cuishuang wants to merge 1 commit into
Open
[material_ui] Port flutter/flutter #190206 "Prevent stale async suggestions in SearchAnchor"#12478cuishuang wants to merge 1 commit into
cuishuang wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates SearchAnchor to prevent stale asynchronous suggestions from overwriting newer results. It introduces an internal counter, _suggestionsCallId, to track suggestion requests and discard results from outdated calls. A new test case has been added to verify that out-of-order asynchronous suggestions are ignored. No review comments were provided, and there is no feedback to provide.
10 tasks
cuishuang
force-pushed
the
port-190206-search-anchor
branch
from
August 16, 2026 01:09
ae1683b to
e6b6758
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports flutter/flutter#190206 to
material_uifollowing flutter/flutter#188444.Fixes flutter/flutter#190205.
This change prevents an older asynchronous
SearchAnchor.suggestionsBuilderrequest from replacing the results of a newer request.It assigns an incrementing ID to each suggestions request and only applies the result when it still represents the latest request.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2