Skip to content

[material_ui] Port flutter/flutter #190206 "Prevent stale async suggestions in SearchAnchor" - #12478

Open
cuishuang wants to merge 1 commit into
flutter:mainfrom
cuishuang:port-190206-search-anchor
Open

[material_ui] Port flutter/flutter #190206 "Prevent stale async suggestions in SearchAnchor"#12478
cuishuang wants to merge 1 commit into
flutter:mainfrom
cuishuang:port-190206-search-anchor

Conversation

@cuishuang

@cuishuang cuishuang commented Aug 16, 2026

Copy link
Copy Markdown

Ports flutter/flutter#190206 to material_ui following flutter/flutter#188444.

Fixes flutter/flutter#190205.

This change prevents an older asynchronous SearchAnchor.suggestionsBuilder request from replacing the results of a newer request.

It assigns an incrementing ID to each suggestions request and only applies the result when it still represents the latest request.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Aug 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates SearchAnchor to prevent stale asynchronous suggestions from overwriting newer results. It introduces an internal counter, _suggestionsCallId, to track suggestion requests and discard results from outdated calls. A new test case has been added to verify that out-of-order asynchronous suggestions are ignored. No review comments were provided, and there is no feedback to provide.

@cuishuang
cuishuang force-pushed the port-190206-search-anchor branch from ae1683b to e6b6758 Compare August 16, 2026 01:09
@Piinks Piinks added triage-design Should be looked at in design triage and removed triage-framework Should be looked at in framework triage labels Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SearchAnchor can show stale results when async suggestions complete out of order

2 participants