Skip to content

[camera_web] Skip video input devices that cannot be started in availableCameras - #13196

Open
Anfet wants to merge 6 commits into
flutter:mainfrom
Anfet:camera_web-skip-unreadable-cameras
Open

Anfet wants to merge 6 commits into
flutter:mainfrom
Anfet:camera_web-skip-unreadable-cameras

Conversation

@Anfet

@Anfet Anfet commented Oct 11, 2026

Copy link
Copy Markdown

availableCameras opens every video input device to read its facing mode. If one device cannot be started (for example the OBS Virtual Camera on Windows while OBS is not running), getUserMedia rejects with NotReadableError and the whole call throws cameraNotReadable, so the cameras that work are not returned either.

This PR skips a device whose stream cannot be started and continues with the remaining devices. If no camera is available and a device failed, the first device error is still thrown, so a single broken camera keeps reporting its error instead of returning an empty list.

The platform interface documents that availableCameras returns an empty list when no cameras are available. availableCameras already throws today when a device cannot be started, and this PR keeps that behavior when no device can be started at all, so a single busy or broken camera still reports why it failed. I'm happy to return an empty list instead if that is preferred.

Fixes flutter/flutter#194184

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the camera_web package to version 0.3.5+7. The availableCameras method in CameraPlugin is modified to catch CameraWebException when retrieving the video stream for a device, allowing other functional cameras to be listed instead of failing the entire call. If no cameras are successfully retrieved, the first caught exception is thrown. Integration tests are added to verify these scenarios. There are no review comments, and there is no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[camera_web] availableCameras throws cameraNotReadable when one video device cannot be opened (e.g. OBS Virtual Camera)

1 participant