Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the camera_web package to version 0.3.5+7. The availableCameras method in CameraPlugin is modified to catch CameraWebException when retrieving the video stream for a device, allowing other functional cameras to be listed instead of failing the entire call. If no cameras are successfully retrieved, the first caught exception is thrown. Integration tests are added to verify these scenarios. There are no review comments, and there is no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
availableCamerasopens every video input device to read its facing mode. If one device cannot be started (for example the OBS Virtual Camera on Windows while OBS is not running),getUserMediarejects withNotReadableErrorand the whole call throwscameraNotReadable, so the cameras that work are not returned either.This PR skips a device whose stream cannot be started and continues with the remaining devices. If no camera is available and a device failed, the first device error is still thrown, so a single broken camera keeps reporting its error instead of returning an empty list.
The platform interface documents that
availableCamerasreturns an empty list when no cameras are available.availableCamerasalready throws today when a device cannot be started, and this PR keeps that behavior when no device can be started at all, so a single busy or broken camera still reports why it failed. I'm happy to return an empty list instead if that is preferred.Fixes flutter/flutter#194184
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2