Update fwe samples (pt2 of 3) - Resubmission#13196
Conversation
|
@parlough Ok - I've updated the code and resubmitted this. PTAL. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully addresses compilation issues, JSON decoding cast warnings, and incorporates immutable data class best practices as outlined in the description. The changes primarily involve updating code examples and tutorial content to reflect these improvements, ensuring consistency and correctness across the project files. However, there are a few areas where further refinement can enhance code quality and tutorial clarity.
|
Visit the preview URL for this PR (updated for commit 5110dc6): https://flutter-docs-prod--pr13196-resubmit-13156-tebo9iok.web.app |
There was a problem hiding this comment.
Thanks for coming back to this @lamek! I appreciate it :D
The other files look good to me, but the steps and code snippets don't align in listenable-builder.md yet. I left comments on the first few cases, but it continues on from there.
Let me know if you have any questions, hit any issues, or would like to go through it together. Thanks again!
Also don't worry about it for this PR, but I imagine we can reuse the same file for more steps. Docregions can be opened and closed multiple times within the same file. When I have time, I'll open a PR consolidating some excerpts with some examples.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Co-authored-by: lamek <kevin.lamenzo@gmail.com>
parlough
left a comment
parlough
left a comment
There was a problem hiding this comment.
Thanks for coming back to this Kevin! Looks good to me. Do note I pushed some additional changes:
- Incorporated your changes from the other PR.
- Reduced some of the changes from the listenable-builder lesson to keep the related instructions accurate and this PR smaller and easier to review. With the excerpts in place we can revisit further changes as follow up.
- Fixed a few lints.
- Cleaned up the Dart API doc comments in a few snippets.
Let me know if you have any concerns or questions about those changes. I have some follow up changes I plan to work on as well so happy to address them as part of that.
3 participants
This resubmits PR #13156, and integrates fixes to resolve the reverted compilation issues, JSON decoding cast warnings, and immutable data class best practices.