Add timeline for breaking changes in raw-menu-anchor-close-order#13287
Open
davidhicks980 wants to merge 1 commit intoflutter:mainfrom
Open
Add timeline for breaking changes in raw-menu-anchor-close-order#13287davidhicks980 wants to merge 1 commit intoflutter:mainfrom
davidhicks980 wants to merge 1 commit intoflutter:mainfrom
Conversation
Added timeline section with versioning details.
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a Timeline section to the breaking changes documentation for RawMenuAnchor. The review feedback suggests replacing the HTML line break tag with a Markdown list to adhere to style guidelines and improve readability.
Comment on lines
+124
to
+125
| Landed in version: 3.44.0-0.1.pre<br> | ||
| In stable release: TBD |
Contributor
There was a problem hiding this comment.
The use of the <br> tag violates the Google Developer Documentation Style Guidelines, which this PR aims to follow. Instead of using HTML tags for line breaks, use a Markdown list for better structure and consistency with the rest of the document.
Suggested change
| Landed in version: 3.44.0-0.1.pre<br> | |
| In stable release: TBD | |
| * Landed in version: 3.44.0-0.1.pre | |
| * In stable release: TBD |
References
- The Google Developer Documentation Style Guide explicitly advises against using the
tag and recommends using lists for related items. (link)
Collaborator
|
Visit the preview URL for this PR (updated for commit e695cf9): https://flutter-docs-prod--pr13287-timeline-bm2lqf1r.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why:
Adds a timeline for breaking changes in raw-menu-anchor-close-order. I didn't fill in the stable version yet -- should I?
PRs or commits this PR depends on (if any):
flutter/flutter#182357
@dkwingsmt
Presubmit checklist
of 80 characters or fewer.