Skip to content

refactor(package_info_plus): use win32's built-in structs and helpers #3806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
halildurmus wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −37
Open

refactor(package_info_plus): use win32's built-in structs and helpers #3806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 4 additions & 35 deletions packages/package_info_plus/package_info_plus/lib/src/file_attribute.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,6 @@ import 'dart:io';
import 'package:ffi/ffi.dart';
import 'package:win32/win32.dart';

base class FILEATTRIBUTEDATA extends Struct {
@DWORD()
external int dwFileAttributes;

external FILETIME ftCreationTime;

external FILETIME ftLastAccessTime;

external FILETIME ftLastWriteTime;

@DWORD()
external int nFileSizeHigh;

@DWORD()
external int nFileSizeLow;
}

class FileAttributes {
final String filePath;

Expand All @@ -43,7 +26,7 @@ class FileAttributes {
}

final lptstrFilename = filePath.toPcwstr();
final lpFileInformation = calloc<FILEATTRIBUTEDATA>();
final lpFileInformation = calloc<WIN32_FILE_ATTRIBUTE_DATA>();

try {
final result = GetFileAttributesEx(
Expand All @@ -55,29 +38,15 @@ class FileAttributes {
throw WindowsException(result.error.toHRESULT());
}

final FILEATTRIBUTEDATA fileInformation = lpFileInformation.ref;
final WIN32_FILE_ATTRIBUTE_DATA fileInformation = lpFileInformation.ref;

return (
creationTime: fileTimeToDartDateTime(fileInformation.ftCreationTime),
lastWriteTime: fileTimeToDartDateTime(fileInformation.ftLastWriteTime),
creationTime: fileInformation.ftCreationTime.toDateTime(),
lastWriteTime: fileInformation.ftLastWriteTime.toDateTime(),
);
} finally {
free(lptstrFilename);
free(lpFileInformation);
}
}

static DateTime? fileTimeToDartDateTime(FILETIME? fileTime) {
if (fileTime == null) return null;

final high = fileTime.dwHighDateTime;
final low = fileTime.dwLowDateTime;

final fileTime64 = (high << 32) + low;

final windowsTimeMillis = fileTime64 ~/ 10000;
final unixTimeMillis = windowsTimeMillis - 11644473600000;

return DateTime.fromMillisecondsSinceEpoch(unixTimeMillis);
}
}
4 changes: 2 additions & 2 deletions packages/package_info_plus/package_info_plus/lib/src/file_version_info.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
// found in the LICENSE file.

// Inspired by:
// - github.com/chromium/chromium/src/base/file_version_info_win.cc
// - github.com/timsneath/win32/example/filever.dart
// - github.com/chromium/chromium/blob/main/base/file_version_info_win.cc
// - github.com/halildurmus/win32/blob/main/examples/filever.dart

import 'dart:ffi';
import 'dart:io';
Expand Down
Loading