feat: PushIdentityReconciled and the push soft prompt - #39
Conversation
… soft prompt NotificationManager.onPushIdentityReconciled emits (intent, converged, error) for every reconcile pass that had a driver, after the pass, only when the intent did not move under it, so a host that reports device state per person can follow the identity the package now declares. PushPrompt, PushPromptHost and PushOffNotice move here from an app: four presentations of pushPromptAdvice, a decline timestamp under a host-supplied vault key, re-reads on the driver's permission and identity streams and on a driver attached after mount, and an onOpenPreferences callback instead of a starter route. Copy through notifications.push_prompt.* keys, documented. No version bump.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Note Kodizm (AI-generated). May contain mistakes; verify before acting. Looks correct and ready to merge; two minor points below. The new emit in Minor
Tests
CI
|
…ument the prompt in the README
|
@kodizm review. Both minors fixed: a generation counter drops a stale read that lands after a decline (new widget test, red first), and the README documents the prompt widgets and onPushIdentityReconciled. |
|
Note Kodizm (AI-generated). May contain mistakes; verify before acting. Both earlier minors are fixed and this is ready to merge. One narrow ordering is still open, noted below as optional. Since the last review, commit Minor
TestsThe new widget test CI
|
|
@kodizm review. The optional ordering is fixed too: the decline takes its generation only after the vault write lands, so a read that starts during the write is the stale one, and a failed write drops nothing (new widget test holding the write open, red first). |
|
Note Kodizm (AI-generated). May contain mistakes; verify before acting. The ordering fix is correct and I have no findings left. Wait for CI to finish before merging. Since the last review, commit
The increment runs synchronously right after the TestsThe new widget test CI
|
feat: emit PushIdentityReconciled per identity pass and ship the push soft prompt
NotificationManager.onPushIdentityReconciled emits (intent, converged, error)
for every reconcile pass that had a driver, after the pass, only when the
intent did not move under it, so a host that reports device state per person
can follow the identity the package now declares.
PushPrompt, PushPromptHost and PushOffNotice move here from an app: four
presentations of pushPromptAdvice, a decline timestamp under a host-supplied
vault key, re-reads on the driver's permission and identity streams and on a
driver attached after mount, and an onOpenPreferences callback instead of a
starter route. Copy through notifications.push_prompt.* keys, documented.
No version bump.
Part of the "framework-level support" round (plan 2 of 3): code that uptizm carried because a plugin lacked a seam moves into the owning package. Companion PRs: fluttersdk/magic, fluttersdk/magic_starter, fluttersdk/magic_notifications, fluttersdk/magic_deeplink, fluttersdk/wind, fluttersdk/magic_sentry, and the uptizm adoption.
This PR compiles and tests against its siblings' current default branches; nothing here depends on another PR in the round being merged first. No version bump and no publish.