chore: bring the repository to the ecosystem standard - #4
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Note Kodizm (AI-generated). May contain mistakes; verify before acting. Looks correct to merge: it changes docs, tooling and repo config only, no package code, and the new rules match the code. I checked the claims in the new
Minor
TestsNot needed: no Dart source changed, and the existing 38-test suite still covers the package. CI
|
|
Round 2. Minor, The same gap exists in the siblings this @kodizm please re-review. |
|
Note Kodizm (AI-generated). May contain mistakes; verify before acting. Still good to merge. The one Minor from round 1 is fixed, and nothing new came up. Since the last review, the only new commit is 978a529. It changes TestsNone needed, since no Dart source changed. The existing suite still covers the package. CI
|
Brings magic_sentry, published as 0.0.1 today, to the shape its sibling plugins (magic_deeplink, magic_notifications, magic_payments) already carry. No package code moves.
Added, adapted to sentry
.claude/rules/tests.mdNetworkDrivercontract double,MagicRouter.reset()around a boot, the unreachable-DSNSentry.init, the static breadcrumb remover, barrel imports (the existing suites use them).claude/rules/flutter.mdMagic.initorder,Sentry.isEnabledgating, one owner for HTTP reporting, hardcoded privacy defaults, no config names in the barrel.claude/commands/release.mdmain(release/X.Y.Z,chore(release): X.Y.Z, tag the merge commit), plus theplugin-sentry.mdstamp in the magic repo.claude/settings.json.github/ISSUE_TEMPLATE/*.github/dependabot.ymlsentrygroup sosentry_flutterandsentry_diomove in one PR.github/workflows/dependabot-auto-merge.ymlbranches: [main].pubignore,.worktreeinclude.gitignore.claude/worktrees/only, so the rules above are trackedci.ymlandpublish.ymlalready match the siblings line for line, so they are untouched. No sibling plugin carries a GitHub release job or acodecov.yml(social_auth's is justified by its platform-channel SDKs), so neither is added.Drift fixed
CLAUDE.mdandREADME.mdarchitecture trees were missingevent_breadcrumbs.dart; the data-flow paragraph now names theEvent.listenAnylistener.CLAUDE.mdPost-Change Checklist gains the step for../magic/skills/magic-framework/references/plugin-sentry.md, and the CI section namespublish.yml, the manual 0.0.1 upload, the auto-merge workflow and the release pattern.README.mdintro now mentions the event breadcrumbs;doc/getting-started/installation.mdRequirements states themagic0.0.22 floor and why.Gates
dart format --output=none --set-exit-if-changed .11 files, 0 changed.flutter analyze --no-fatal-infosno issues.flutter test38 passed.dart pub publish --dry-run0 warnings, and the archive no longer carries.claude/,CLAUDE.mdor.github/.