fix(stdlib): defn records a qualified arglist :tag, sort carries metadata - #164
Merged
Merged
Conversation
resolve-tag writes (.FullName c), so a hint like ^Regex is stored as System.Text.RegularExpressions.Regex and resolves from any namespace. It wrote (.Name c), which drops the namespace, defeating the point of the branch: it exists to turn a short tag into a name that stands on its own. The analyzer infers an invoke's static type from the matching arglist's tag, so this changes emission wherever a dotless tag is recorded.
sort wraps its result with (meta coll), so the sorted seq keeps the metadata, as Clojure 1.10 does. sort-by goes through sort and gains it too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #162, Closes #163
resolve-tagwrites.FullName, so adefnarglist:tagrecords a qualified name that resolves from any namespace.sortwraps its result with(meta coll), so the sorted seq keeps the collection's metadata.clojure.instantrefreshes too:instant.clj:265carries the stdlib's one dotless^DateTimeOffsetarglist tag, so its recorded name gains theSystem.prefix.