fix(stdlib): a namespace map prints its keys in the map's own order - #168
Merged
Conversation
…165) lift-ns collects [key value] pairs into a vector and print-prefix-map takes those pairs, so #:a{...} prints in the order the map seqs. lift-ns used to accumulate into a map and rebuild with (apply conj (empty m) lm), so once the accumulator outgrew an array-map the original order was gone. qualified-ident? replaces the (or (keyword? k) (symbol? k)) guard, which matches what upstream did in CLJ-2469.
…p key order fix (#165)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #165
lift-nscollects[key value]pairs into a vector andprint-prefix-maptakes those pairs, so#:a{...}prints in the order the map seqs instead of losing it once the accumulator outgrows an array-map.qualified-ident?replaces the(or (keyword? k) (symbol? k))guard.