fix(mage): il/type's short arities reach the full one - #170
Merged
Conversation
The 5-arity called type with 6 arguments and the next arity takes 7, so every arity below the 7-arity threw ArityException. It now passes the missing custom-attributes as [], the way method does directly below it. The README's Quick Example goes back to the short form, and a new magic.test.mage checks each arity against the full one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #143
il/typecalledtypewith 6 arguments and the next arity takes 7, so every arity below the 7-arity threwArityException. It now passes the missingcustom-attributesas[], the waymethoddoes directly below it.mage/README.md's Quick Example goes back to the short form, replacing the paragraph that documented the breakage.magic.test.magechecks each short arity against the full one. It is mage's first test namespace, so it is registered in both lists inmagic-compiler/test.clj.