fix(stdlib): match JVM behaviour in clojure.string/split - #175
Merged
Conversation
.NET's Regex.Split has none of Java's three split rules, so they are applied here. Java drops trailing empty strings at limit 0. It returns every part at a negative limit. It also drops a leading empty part when the pattern matches nothing at the start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #174
clojure.string/splitnow drops trailing empty strings. A negative limit returns every part. A pattern that matches nothing at the start no longer adds a leading"". .NET'sRegex.Splitcarries none of those three rules, so forwarding to it lost all three.(split "" #",")stays[""], and(split "," #",")is[]. Java returns the input unsplit when nothing matches, before it drops anything.