fix(error-code): sanitize non-UTF-8 bytes from ec.message() (fixes #4436) - #4918
Closed
yunaremaia wants to merge 1 commit into
Closed
fix(error-code): sanitize non-UTF-8 bytes from ec.message() (fixes #4436)#4918yunaremaia wants to merge 1 commit into
yunaremaia wants to merge 1 commit into
Conversation
…tlib#4436) On Windows, std::error_code::message() may return a string in a system code page (e.g. CP-1252) containing bytes invalid in UTF-8. When formatted with {:s}, this caused encoding errors / crashes. Adds detail::append_utf8_sanitized() which validates UTF-8 input and replaces invalid byte sequences with U+FFFD (replacement character). The std::error_code formatter now uses this helper instead of appending ec.message() directly.
Author
|
CI hasn't been triggered yet on this PR. Could you re-run the workflow or let me know if there's anything I need to do to trigger CI checks? |
Contributor
|
Thanks for the PR but this would just mask a bug in Microsoft STL, please see #4884 for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, std::error_code::message() may return a string in a system code page (e.g. CP-1252) containing bytes invalid in UTF-8. When formatted with {:s}, this caused encoding errors/crashes (issue #4436).
Adds detail::append_utf8_sanitized() which validates UTF-8 input and replaces invalid byte sequences with U+FFFD (replacement character). The std::error_code formatter now uses this helper instead of appending ec.message() directly.
Test: std_test.error_code includes a direct test of the sanitize helper with non-UTF-8 input. All existing tests pass.