Skip to content
This repository was archived by the owner on Mar 10, 2018. It is now read-only.

Comments

Extract hardcoded strings for blank slate on coupons#index#5

Open
cabgfx wants to merge 5 commits intofnando:masterfrom
cabgfx:extract-blank-slate-translations
Open

Extract hardcoded strings for blank slate on coupons#index#5
cabgfx wants to merge 5 commits intofnando:masterfrom
cabgfx:extract-blank-slate-translations

Conversation

@cabgfx
Copy link
Contributor

@cabgfx cabgfx commented Oct 8, 2015

I’ve set up a group for blank slate translations, with “sub-groups” that follow the regular pattern of anchored view translations:

blank_slate:
  controller_action:
    key: value

Idea being, to stick future blank slate strings in this group.
Let me know what you think of this, I'm happy to set it up differently.

To-do

  • pt-BR translations

cabgfx added a commit to cabgfx/coupons that referenced this pull request Oct 8, 2015
@cabgfx
Add danish translations
b3596c2 
- Will need an update, if/when PR fnando#5 is merged (ref. bfd51f4)
@cabgfx cabgfx mentioned this pull request Oct 8, 2015
Merged
1 task
@cabgfx
Copy link
Contributor Author

cabgfx commented Oct 11, 2015

Oh, now there's the Kaminari translations. Would be nice if you update them as well. :)

Yes, happy to. But where do I find those?

@cabgfx
Copy link
Contributor Author

cabgfx commented Oct 11, 2015

Sorry, found them :)

@cabgfx
Copy link
Contributor Author

cabgfx commented Oct 11, 2015

PR should be good to go 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cabgfx @fnando