feat(packages): migrate package endpoints to holdingsIQ v2 API#687
Merged
Conversation
- Extract validation into FilterValidators with strategy pattern per RecordType (OCP) - Move TagFilter/AccessTypeFilter creation to static from() factory methods (SRP) - Consolidate duplicate validatePackageFilterType/validateTitleFilterType into single parameterized validateFilterType method (DRY) - Rename type-converting getters to explicit resolve*/parse* methods, letting Lombok generate raw-value getters for clean separation - Filter is now a focused data holder with only its own state accessors Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…tions - Filter is now a sealed interface with ProviderFilter, PackageRecordFilter, ResourceFilter, and TitleFilter implementations - Each type carries only its relevant fields (ISP compliance) - Validation is self-contained per type via FilterValidators - TagFilter.from() and AccessTypeFilter.from() use pattern matching on sealed types instead of RecordType switches - Removed dead code: prepareFilterForPackage(), prepareFilterForResource(), getSortableFilter(), getPackageFilter() helper methods - Removed FilterValidator strategy interface (no longer needed) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
viacheslavkol
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Migrate Package Endpoints to HoldingsIQ v2 API
Approach
Changes Checklist
Related Issues
https://folio-org.atlassian.net/browse/MODKBEKBJ-804