fix(context): normalize file paths for Windows compatibility#263
Open
john-mutuma wants to merge 5 commits intofolke:mainfrom
Open
fix(context): normalize file paths for Windows compatibility#263john-mutuma wants to merge 5 commits intofolke:mainfrom
john-mutuma wants to merge 5 commits intofolke:mainfrom
Conversation
fix(tmux): forward nav keys directly to mux pane on Windows (psmux)
fix(tmux): run set-option as separate commands on Windows for psmux compatibility
7516196 to
c82264a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows,
{file}and other context variables that useLoc.get()send garbled paths. For example,{file}forlua/sidekick/text.luasends@luainstead of@lua/sidekick/text.lua— backslashes in the path are interpreted as escape characters by CLI tools.Root cause
In
lua/sidekick/cli/context/location.lua,vim.api.nvim_buf_get_name()returns backslash paths on Windows (e.g.,C:\Users\...\lua\sidekick\text.lua), but the value is never normalized. Thecwdfallback (vim.fn.getcwd(0)) has the same issue. This causesvim.fs.relpathto produce backslash-separated relative paths that break when sent to CLI tools.Fix
Normalize both
nameand thecwdfallback withvim.fs.normalize(), consistent with how paths are handled elsewhere in the codebase (e.g.,context/init.lua:209normalizescwd).Testing
Tested on Windows 11 with psmux.
{file}now correctly sends@lua/sidekick/text.luainstead of@lua.