Draft
Conversation
Contributor
|
This PR is two years old know, close or rebase? |
Collaborator
Author
|
It may need a rebase and investigation. I think I fished those strings out of a real .glyphs file. |
Contributor
|
We need to first know if it is still an issue. |
eaabbd8 to
140f409
Compare
Collaborator
Author
|
Rebased on master, seems so. |
Contributor
|
Looks like only two of the strings fail: and The first one is quite bizarre, though. |
Member
|
They both look invalid to me, they should have quotes wrapping around as they contain space or special characters like inner quotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why does this fail?