fix: polymarket deprecated endpoint update#233
Open
nikbpetrov wants to merge 2 commits into
Open
Conversation
…ror does not break the job
Update deprecated endpoint, add server-side liquidity_num_min filtering, fix request limiting, and dedupe fetched markets. Closes forecastingresearch#194
19a9225 to
f5a3f87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #194
No clue actually why the
liquidity_num_minparam was not used for server-side filtering; it results in more consistent behaviour and 10x fewer requests; i've tested and validated this param and it works as expected; the5ff64b0commit adds this (still keeping the client-side filtering for robustness)fixes a dormant bug where the
/marketsendpoint can onlyoffsetup to 2500, while the qualifying markets are ~1000 more at the moment. Verified with: