Conversation
Co-authored-by: Copilot <copilot@github.com>
There was a problem hiding this comment.
Pull request overview
This PR expands Decimal128’s formatting and introspection surface by consolidating scientific formatting into to_string(...), adding engineering notation and digit-group separator support, and introducing several small utility/dunder methods consistent with the existing BigDecimal API shape.
Changes:
- Consolidate
to_string_scientific()intoDecimal128.to_string(scientific=..., engineering=..., delimiter=...), adding engineering notation and mantissa digit grouping. - Add
__bool__,__pos__,is_positive(),is_odd(),number_of_trailing_zeros(), plusto_scientific_string()/to_eng_string()/to_string_with_separators()aliases. - Add comprehensive tests for the new formatting paths and utility methods; update docs/changelog to describe the API changes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/decimo/decimal128/decimal128.mojo |
Implements consolidated to_string(...), engineering formatting, digit separator insertion helper, and new utility/dunder methods; removes some prior APIs. |
tests/decimal128/test_decimal128_methods.mojo |
Adds tests covering scientific/engineering formatting, delimiter grouping, __bool__, __pos__, and new utility methods. |
docs/changelog.md |
Documents the new APIs and the to_string consolidation/removals. |
docs/plans/decimal128_enhancement.md |
Updates the Decimal128 audit plan notes and adds an “API additions” section + updated priority summary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands
Decimal128’s formatting and introspection surface by consolidating scientific formatting intoto_string(...), adding engineering notation and digit-group separator support, and introducing several small utility/dunder methods consistent with the existingBigDecimalAPI shape.Changes:
to_string_scientific()intoDecimal128.to_string(scientific=..., engineering=..., delimiter=...), adding engineering notation and mantissa digit grouping.__bool__,__pos__,is_positive(),is_odd(),number_of_trailing_zeros(), plusto_scientific_string()/to_eng_string()/to_string_with_separators()aliases.