fix(ci): name the major each pinned action sha actually is - #464
Merged
Conversation
Seven action pins here carried a comment naming a different major than the sha resolves to: five `actions/checkout # v6` whose sha is v7.0.1, and one `actions/upload-artifact # v4` whose sha is v7. The comment is the only human-readable part of a sha pin -- nobody audits `3d3c42e5` directly -- so one naming the wrong major answers the audit question confidently and wrongly. That is worse than no comment. Nothing here is a version change: every sha is untouched. Only the comments move, to say what the shas already were. Cause, for the next reader: dependabot rewrites a pin comment only when it can parse a precise version out of the existing one. A pin whose comment reads `# v6` gives it nothing to rewrite, so a bump across a major boundary updates the sha and leaves the comment behind, silently and permanently. checkout gets `# v7.0.1` because that sha resolves to a precise release. upload-artifact gets `# v7` because upstream publishes only a moving major tag there -- naming a precise version it does not offer would be inventing one. Verified with utilities/check-action-pin-comments.py: 21 pins checked here, 0 naming the wrong major after this change. Fleet-wide the same check found ten, seven of which were in this repo.
forkwright
pushed a commit
that referenced
this pull request
Sep 3, 2026
🤖 I have created a release *beep* *boop* --- ## [0.6.2](v0.6.1...v0.6.2) (2026-09-03) ### Bug Fixes * **akroasis:** correct Pinax authority boundary ([#476](#476)) ([0a6cc23](0a6cc23)) * **ci:** name the major each pinned action sha actually is ([#464](#464)) ([5306eb2](5306eb2)) * **kerykeion:** drop the redundant Instrument import from collector_tests ([#471](#471)) ([2b2e0ee](2b2e0ee)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven action pins here carried a comment naming a different major than the sha
resolves to: five
actions/checkout # v6whose sha is v7.0.1, and oneactions/upload-artifact # v4whose sha is v7.The comment is the only human-readable part of a sha pin -- nobody audits
3d3c42e5directly -- so one naming the wrong major answers the audit questionconfidently and wrongly. That is worse than no comment.
Nothing here is a version change: every sha is untouched. Only the comments
move, to say what the shas already were.
Cause, for the next reader: dependabot rewrites a pin comment only when it can
parse a precise version out of the existing one. A pin whose comment reads
# v6gives it nothing to rewrite, so a bump across a major boundary updates the sha
and leaves the comment behind, silently and permanently.
checkout gets
# v7.0.1because that sha resolves to a precise release.upload-artifact gets
# v7because upstream publishes only a moving major tagthere -- naming a precise version it does not offer would be inventing one.
Verified with utilities/check-action-pin-comments.py: 21 pins checked here,
0 naming the wrong major after this change. Fleet-wide the same check found ten,
seven of which were in this repo.