fix(ci): repair release-checks caller permission - #153
Merged
Conversation
The fleet reusable at forkwright/.github@5556cb9 added checks: read. The caller permission cap must include it because reusable workflows cannot elevate the caller token; its omission caused startup_failure runs with zero jobs.
Owner
Author
|
Post-merge verification: run https://github.com/forkwright/logismos/actions/runs/33994213613/job/101381698351 now starts, passes the shared helper's self-tests and successfully approves three held runs. This establishes that the caller permission repair works. The helper then made an immediate empty-rollup observation; checks appeared seconds later. That distinct shared-reusable timing defect is tracked at forkwright/.github#71 and does not justify broader permissions. The release PR's remaining GPU-denied check failure is a stale workspace Cargo.lock after its version bump, not a boundary regression. Release PR #152 has not been edited or merged by this lane. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Grant only
checks: readto the release-checks caller, matching the shared reusable workflow's declared permission. Also correct one API doc sentence left over from the former implicit HIP fallback:NoGpuBuildnow means an explicit CPU-only build.Evidence
The shared reusable added
checks: readin forkwright/.github PR #70, revision 5556cb9. The caller's permission cap can only reduce the callee's permissions. Logismos did not include that read scope, so run 33993648179 failed at startup with zero jobs. This predates foundation PR #151: the caller was unchanged from 7a24c6d to a0f4250, and run 33990070268 already had the same failure. Last successful checks used reusable d1a82c9; failures began when it resolved 5556cb9 on September 3.Validation and limits
Static YAML parse and
git diff --checkpassed. Normal PR CI checks the integrated tree. No trigger, secret, credential, GPU/device permission, or service configuration changes; this grants read access to check runs only. Post-merge workflow startup will establish the permission repair.