Optimize bitvector numeral creation in solvers#593
Merged
redianthus merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
Contributor
|
Great, thanks! I think this is actually exactly the kind of cases where Smtml can particularly shine compared to :
|
0fe9012 to
e53016d
Compare
Member
Author
Exactly, I think this is another good argument for smtml 😃 Btw, I didn't use I don't know if they're releasing it anytime soon |
Contributor
|
I tried and it looks quite good! I don't see an issue anymore, so I think we can merge. :) |
- Bitwuzla: Now uses `mk_bv_value_int` or `mk_bv_value_int64` when possible. - Z3: Uses `mk_numeral_int` when possible. - Dolmen (Alt-Ergo/Colibri2): Directly creates bitstrings from Z.t in of_z, avoiding a string roundtrip. - Mappings: uses the more optimal of_z.
e53016d to
32d511e
Compare
redianthus
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mk_bv_value_intormk_bv_value_int64when possible.mk_numeral_intwhen possible.cc @redianthus. I think most of the times this should use the more optimized version?