optimize Hashtbl.replace -> Hashtbl.add#596
Merged
filipeom merged 3 commits intoformalsec:mainfrom Apr 13, 2026
Merged
Conversation
filipeom
approved these changes
Apr 13, 2026
Member
filipeom
left a comment
There was a problem hiding this comment.
Is it because Hashtbl.add is faster in the happy path?
Contributor
Author
|
Yes, if you look at the implementation in the stdlib you'll see it is doing much less work (or maybe it's not in the happy path but simply becaus ewe have collisions and in this case, add is also better than replace). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was showing up a little bit too much in my measurements (the one in
expr.mlbut I thought changing the others would do no harm).EDIT: in the end I went with removing the Hashtbl, using a list is fine because 1. we never need to concatenate two lists, as we simply add one symbol at a time and 2. we can simply use
List.sort_uniqat the end, which should be fine as there shouldn't be too many symbols.