fix(security): floor Bouncy Castle, freemarker and commons-lang3 in the build toolchain - #86
Merged
Conversation
…he build toolchain Clears Dependabot alerts #52-#55. All four are build tooling only; none reaches the published AAR. - bcprov 1.84: Kotlin 2.4's kotlinBouncyCastleConfiguration, an :android configuration the securityFloors map did not cover. - freemarker 2.3.32: Dokka 2.2.0's generator runtime. - commons-lang3 3.16.0: brought onto AGP's plugin classpath by the commons-compress 1.27.1 floor.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mattinannt
approved these changes
Sep 30, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What & why
Was: 4 Dependabot alerts open, two of them critical, and one already past its SLA. No open Dependabot PR touches these packages.
Now: all four packages are raised to patched versions, which clears alerts 52–55.
kotlinBouncyCastleConfiguration(its PGP / signing check tasks)Bouncy Castle was already floored at 1.85 on AGP's plugin classpath (#79). This copy lives in an
:androidconfiguration, which only thesecurityFloorsmap reaches. Dependabot credits both classpaths tosettings.gradle.kts, so they look the same in the alert.Where to look
android/build.gradle.kts: two newsecurityFloorsentriesbuild.gradle.kts: the commons-lang3 constraintgradle/libs.versions.toml: two new versions, and the comment on which classpath each floor coversNothing ships
releaseRuntimeClasspathcarries none of these, and the generated POM lists only the SDK's own dependencies.Coverage
Rerun:
./gradlew :android:dependenciesand./gradlew buildEnvironment, then./gradlew :android:assembleRelease :android:testReleaseUnitTest :android:dokkaJavadocJar :android:generatePomFileForMavenPublication1.84→1.85, freemarker2.3.32→2.3.35in both Dokka resolvers, commons-lang33.16.0→3.21.0dokkaJavadocJarchecks Dokka on freemarker 2.3.35releaseRuntimeClasspathmatches none of the fourOpen gaps
dependency-submission.ymlonly runs onpush: main.