Skip to content

chore: remove Formbricks Hub MCP server references - #113

Merged
xernobyl merged 2 commits into
mainfrom
chore/ENG-1975_remove-hub-mcp-references
Jul 28, 2026
Merged

chore: remove Formbricks Hub MCP server references#113
xernobyl merged 2 commits into
mainfrom
chore/ENG-1975_remove-hub-mcp-references

Conversation

@xernobyl

Copy link
Copy Markdown
Contributor

What does this PR do?

Removes the Hub's MCP references, per ENG-1975. Matti and Johannes concluded the Hub doesn't need its own MCP server — a second one was confusing customers about which to use, and good APIs are sufficient for the Hub. The feedbackRecord actions now live in the Formbricks XM Suite MCP server instead (formbricks#8650).

The @formbricks/hub-mcp npm package stays published until Stainless is sunset, so existing users keep working. This only stops us pointing new users at it.

Two commits, deliberately separable:

1. docs: — README + OpenAPI (the literal ticket scope)

  • drops the @formbricks/hub-mcp bullet from the README's Ecosystem list
  • reworded the OpenAPI info.description: "generated SDK and MCP clients" → "generated SDK clients"

2. chore: — the opt-in MCP package smoke test ⚠️ beyond the letter of the ticket, drop this commit if you'd rather keep it

tests/mcp_smoke_test.go (823 lines) exists solely to spawn @formbricks/hub-mcp via npx and exercise it against a live Hub. It's opt-in (RUN_MCP_SMOKE_TEST=1), CI never runs it, and it was the only consumer of github.com/modelcontextprotocol/go-sdk — so go mod tidy drops that plus 8 transitive deps. Also removes the mcp-smoke make target, its help line and its .PHONY entry.

The argument for keeping it: the package is still published, so arguably still worth smoke-testing. The argument for removing it: the Hub repo isn't where a discontinued npm package should be tested, and it costs us a Go dependency for nothing else. Happy either way — that's why it's its own commit.

The docs site changes live in a companion PR: stainless-sdks/hub-api-docs#….

How should this be tested?

  • go build ./... and go vet ./... — clean
  • go vet ./tests — the tests package still compiles with the file removed
  • go test ./cmd/api ./internal/... — unit tests pass (also run by the pre-commit hook, along with make fmt and make lint: 0 issues)
  • npx @stoplight/spectral-cli@6 lint openapi.yaml — "No results with a severity of 'error' found!"
  • grep -rniE '\bmcp\b' README.md openapi.yaml Makefile — no remaining references
  • Reviewer sanity check: make help no longer advertises mcp-smoke, and git grep modelcontextprotocol returns nothing

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Repository Guidelines
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran make build
  • Ran make tests (integration tests in tests/) — not run: needs a live test_db with pgvector + goose migrations, and this change adds no runtime behaviour. go vet ./tests confirms the package still compiles without the deleted file, and the deleted test never ran in CI.
  • Ran make fmt and make lint; no new warnings
  • Removed debug prints / temporary logging
  • Merged the latest changes from main onto my branch — branched from a freshly fetched origin/main (ee60d7f)
  • If database schema changed: n/a — no schema changes

Appreciated

  • If API changed: n/a for behaviour, but the OpenAPI info.description was reworded and re-linted
  • If API behavior changed: n/a — no behaviour change
  • Updated docs in docs/ if changes were necessary — the docs site is the companion PR
  • Ran make tests-coverage — n/a, no logic changes (only deletions)

xernobyl added 2 commits July 28, 2026 10:42
The Hub is no longer shipping an MCP story — good APIs are sufficient, and a
second MCP server was confusing customers about which one to use. The
feedbackRecord actions now live in the Formbricks XM Suite MCP server instead.

The @formbricks/hub-mcp npm package stays published until Stainless is sunset,
so existing users keep working; this only stops us pointing new users at it.
tests/mcp_smoke_test.go exists solely to spawn the @formbricks/hub-mcp npm
package via npx and exercise it against a live Hub. With the Hub MCP
discontinued there is nothing here worth maintaining: the test is opt-in
(RUN_MCP_SMOKE_TEST=1), CI never runs it, and it was the only consumer of the
modelcontextprotocol/go-sdk dependency — go mod tidy drops that plus eight
transitive deps.

This goes beyond the letter of ENG-1975 (documentation and README), so it is a
separate commit: drop it if we would rather keep testing the package while it
stays published for existing users.
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

✱ Stainless preview builds

This PR will update the hub SDKs with the following commit message.

chore: remove Formbricks Hub MCP server references
hub-openapi studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅

hub-typescript studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅build ⏭️lint ⏭️test ✅


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-07-28 15:16:03 UTC

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e6cadd2c-5083-4273-a552-8425128cea84

📥 Commits

Reviewing files that changed from the base of the PR and between ee60d7f and b96c46a.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (5)
  • Makefile
  • README.md
  • go.mod
  • openapi.yaml
  • tests/mcp_smoke_test.go
💤 Files with no reviewable changes (3)
  • README.md
  • tests/mcp_smoke_test.go
  • go.mod

Walkthrough

Removed the MCP smoke-test Make target and its supporting Go dependencies. Deleted the MCP Server entry from the README ecosystem list and removed generated MCP clients from the OpenAPI description of PUBLIC_BASE_URL.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, conventional, and accurately summarizes the main change: removing Hub MCP server references.
Description check ✅ Passed The description covers the change, motivation, testing performed, and checklist items, with only some non-critical items left unchecked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@xernobyl
xernobyl enabled auto-merge July 28, 2026 10:59
@xernobyl
xernobyl requested a review from mattinannt July 28, 2026 10:59
@xernobyl
xernobyl added this pull request to the merge queue Jul 28, 2026
Merged via the queue into main with commit 4993dfb Jul 28, 2026
11 checks passed
@xernobyl
xernobyl deleted the chore/ENG-1975_remove-hub-mcp-references branch July 28, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants