chore: remove Formbricks Hub MCP server references - #113
Conversation
The Hub is no longer shipping an MCP story — good APIs are sufficient, and a second MCP server was confusing customers about which one to use. The feedbackRecord actions now live in the Formbricks XM Suite MCP server instead. The @formbricks/hub-mcp npm package stays published until Stainless is sunset, so existing users keep working; this only stops us pointing new users at it.
tests/mcp_smoke_test.go exists solely to spawn the @formbricks/hub-mcp npm package via npx and exercise it against a live Hub. With the Hub MCP discontinued there is nothing here worth maintaining: the test is opt-in (RUN_MCP_SMOKE_TEST=1), CI never runs it, and it was the only consumer of the modelcontextprotocol/go-sdk dependency — go mod tidy drops that plus eight transitive deps. This goes beyond the letter of ENG-1975 (documentation and README), so it is a separate commit: drop it if we would rather keep testing the package while it stays published for existing users.
✱ Stainless preview buildsThis PR will update the ✅ hub-typescript studio · code
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
💤 Files with no reviewable changes (3)
WalkthroughRemoved the MCP smoke-test Make target and its supporting Go dependencies. Deleted the MCP Server entry from the README ecosystem list and removed generated MCP clients from the OpenAPI description of 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
Removes the Hub's MCP references, per ENG-1975. Matti and Johannes concluded the Hub doesn't need its own MCP server — a second one was confusing customers about which to use, and good APIs are sufficient for the Hub. The feedbackRecord actions now live in the Formbricks XM Suite MCP server instead (formbricks#8650).
The
@formbricks/hub-mcpnpm package stays published until Stainless is sunset, so existing users keep working. This only stops us pointing new users at it.Two commits, deliberately separable:
1.
docs:— README + OpenAPI (the literal ticket scope)@formbricks/hub-mcpbullet from the README's Ecosystem listinfo.description: "generated SDK and MCP clients" → "generated SDK clients"2.⚠️ beyond the letter of the ticket, drop this commit if you'd rather keep it
chore:— the opt-in MCP package smoke testtests/mcp_smoke_test.go(823 lines) exists solely to spawn@formbricks/hub-mcpvianpxand exercise it against a live Hub. It's opt-in (RUN_MCP_SMOKE_TEST=1), CI never runs it, and it was the only consumer ofgithub.com/modelcontextprotocol/go-sdk— sogo mod tidydrops that plus 8 transitive deps. Also removes themcp-smokemake target, its help line and its.PHONYentry.The argument for keeping it: the package is still published, so arguably still worth smoke-testing. The argument for removing it: the Hub repo isn't where a discontinued npm package should be tested, and it costs us a Go dependency for nothing else. Happy either way — that's why it's its own commit.
The docs site changes live in a companion PR: stainless-sdks/hub-api-docs#….
How should this be tested?
go build ./...andgo vet ./...— cleango vet ./tests— thetestspackage still compiles with the file removedgo test ./cmd/api ./internal/...— unit tests pass (also run by the pre-commit hook, along withmake fmtandmake lint: 0 issues)npx @stoplight/spectral-cli@6 lint openapi.yaml— "No results with a severity of 'error' found!"grep -rniE '\bmcp\b' README.md openapi.yaml Makefile— no remaining referencesmake helpno longer advertisesmcp-smoke, andgit grep modelcontextprotocolreturns nothingChecklist
Required
make buildmake tests(integration tests intests/) — not run: needs a livetest_dbwith pgvector + goose migrations, and this change adds no runtime behaviour.go vet ./testsconfirms the package still compiles without the deleted file, and the deleted test never ran in CI.make fmtandmake lint; no new warningsorigin/main(ee60d7f)Appreciated
info.descriptionwas reworded and re-linteddocs/if changes were necessary — the docs site is the companion PRmake tests-coverage— n/a, no logic changes (only deletions)