Fixing issues related to login forms and email actions.#29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With some recent application development processes, there are a few issues that were identified.
1.) Login Forms were getting a 'Save Submission' action, which causes strange 'unique' validation errors on login.
2.) Login forms were 'forcing' email + password combination, which is not always the case.
3.) Email actions were using
no-reply@form.ioas 'from' email which is not allowed.4.) Email actions were using
{{ submission._id }}which is not defined.5.) Email actions were using
{{ config.appUrl }}, but no public configurations were added to the project.6.) Some forms were not getting Submit buttons.