Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
**Changes proposed in this pull request:**

* [Change 1]
* [Change 2]
* [Other changes...]

**Public description:**

[Public description of the changes to include in changelog, typically one line will suffice]

[Glossy screenshots if available for the changelog]

- [ ] Internal Improvement (no customer impact)
- [ ] Hide from Changelog

**Have you made sure to add:**
- [ ] Tests
- [ ] Documentation

**Supplemental Screenshots and GIFs**

[Insert screenshot or GIFs of old and new behavior to assist reviewers]

**Steps to Review**

See https://www.notion.so/formspree/Code-Reviews-78c7d523c4424f66a399367a6738ae13

**Any Additional Information or Deployment Notes**

4 changes: 3 additions & 1 deletion src/cmds/deploy.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ exports.builder = yargs => {

yargs.option('force', {
alias: 'f',
describe: 'Skip verifying that secrets reference environment variables',
describe:
'Skip verifying that secrets reference environment variables and force the deployment via the API',
type: 'boolean',
default: false
});
Expand Down Expand Up @@ -169,6 +170,7 @@ exports.handler = async args => {
const response = await deploy.request({
endpoint,
config,
force: args.force,
key,
userAgent
});
Expand Down
2 changes: 2 additions & 0 deletions test/cmds/deploy.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ afterEach(() => {
it('sends a deploy request with the right params', async () => {
deploy.request.mockImplementation(params => {
expect(params.config).toStrictEqual({});
expect(params.force).toBe(false);
expect(params.key).toBe('xxx');
expect(params.userAgent).toBe(`@formspree/cli@${version}`);

Expand Down Expand Up @@ -171,6 +172,7 @@ it('skips validating inline secrets with force flag', async () => {

deploy.request.mockImplementation(params => {
expect(params.config.apiKey).toBe('my-inline-key');
expect(params.force).toBe(true);
return Promise.resolve({
status: 200,
data: { id: 'xxxx-xxxx-xxxx', shim: null }
Expand Down