Doctor: seeded memories state the settled signing shape; a finding names a rule the project may disable - #142
Merged
Conversation
The two seeded memory files carried an unratified evaluation that called disable-library-validation a required companion of ENABLE_DEBUG_DYLIB and floated retiring SPMLibraries. Both now state the shape the templates ship and fosmvvm-doctor audits: one SPMLibraries doorway, app-only embed with re-sign, hardened runtime off in Debug only, ENABLE_DEBUG_DYLIB unset, no entitlement. The index lines follow.
… fosmvvm-review honors it Finding gains an optional rule (DisableableRule, one case: app_sandbox) on the findings a project may hold on purpose, named in SwiftLint's vocabulary. The JSON carries the identifier on those findings only; the text report prints it under the finding. The review skill's .fosmvvm-review.yml gains doctor.disabled_rules (rule, target, reason): a matched finding reports at warning with the reason and no longer halts tier 2. Doctor's own verdict is unchanged. Design addendum, DocC, and plugin 2.64.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two commits, both from the first doctor run against a project the scaffolder never created.
Seeded memories state the settled signing shape. The scaffold's
entitlement-is-a-symptom.mdandxcode16-dynamic-spm-packages.mdcarried an unratified evaluation that calleddisable-library-validationa required companion ofENABLE_DEBUG_DYLIBand floated retiringSPMLibraries. Both now state the shape the templates ship andfosmvvm-doctoraudits: oneSPMLibrariesdoorway, app-only embed with re-sign, hardened runtime off in Debug only,ENABLE_DEBUG_DYLIBunset, no entitlement.A doctor finding can name a rule the project may disable.
Finding.rule(DisableableRule, one case:app_sandbox) marks the few findings a project may hold on purpose, such as an ops app that runs unsandboxed to reach local infrastructure. The JSON carries the identifier on those findings only; the text report prints it under the finding.fosmvvm-reviewgainsdoctor.disabled_rulesin.fosmvvm-review.yml(rule,target,reason), SwiftLint's vocabulary: a matched finding reports at warning with the reason beside it and no longer halts tier 2. Doctor's own verdict is unchanged. Design addendum indocs/work/fosmvvm-doctor-design.md, DocC in CreatingAProject, plugin 2.64.0.Verification
swift test --filter FOSMVVMBootstrapTests: 90 tests in 14 suites pass (two new: the withheld sandbox names its rule; a missing network.client does not).app_sandbox.