Skill text teaches the envelope, not the retired decode order - #145
Merged
Conversation
…not the retired decode order The serverrequest generator's section and the review's no-defensive-error-for-credential-rejection check described WireError's trial decode, which 0.16.0 replaced with a typed envelope on both sides. Both now state the envelope. Plugin 2.67.0.
… brew's latest" This reverts commit f84267c.
…iterals SwiftFormat on the CI runners flags every blank line inside a multiline string literal (indent + trailingSpace). Each blank line becomes an explicit \n on the preceding line; the rendered messages are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The serverrequest generator's credential-rejection section and the review's
no-defensive-error-for-credential-rejectioncheck both describedWireError's trial decode, which 0.16.0 replaced with a typed envelope on both sides. Both now state the envelope; the conclusions they draw (EmptyErroris safe behind a credential middleware; a permissiveStringfield buys nothing) are unchanged. Plugin 2.67.0.Verification
Documentation only — no Swift changed. The two sites were found by grepping the shipped skills for the retired mechanism after the 0.16.0 release.