Fix invalidating cache in the WatchingResolvePathTemplateManager when the source teplate file is renaming#7
Open
vladsm wants to merge 1 commit intofouadmess:masterfrom
Open
Fix invalidating cache in the WatchingResolvePathTemplateManager when the source teplate file is renaming#7vladsm wants to merge 1 commit intofouadmess:masterfrom
vladsm wants to merge 1 commit intofouadmess:masterfrom
Conversation
…chingResolvePathTemplateManager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using WatchingResolvePathTemplateManager to simplify template creation at the development time leveraging change-and-check iterative process without restarting my application.
When trying to change source template file in the Visual Studio it appears that template cache is not invalidating, while with changes in simple text editor everything works fine. The reason is Visual Studion makes files changes by creating temporal files and renaming them to editing ones after all.
In WatchingResolvePathTemplateManager files renamings was handled with emulating two other events: delete file and create file. The issue was in using FileSystemEventArgs constructor calling which accepts file directory as a second argument. But the full path of the file was passed to it. This causes wrong template file invalidating.
I fixed it by explicitly calling invalidating function for "deleted" and "created" files in "file renamed" event handler.