fix(StdCheats): enable packed slots when dealing token balances#888
Open
Yonkoo11 wants to merge 1 commit into
Open
fix(StdCheats): enable packed slots when dealing token balances#888Yonkoo11 wants to merge 1 commit into
Yonkoo11 wants to merge 1 commit into
Conversation
Tokens that pack balance into a shared storage word (USDC-class, Optimism sUSD) fail stdstore find without packed mode. Use enable_packed_slots() for ERC20/1155/721 balance writes so deal updates only the balance bits and preserves neighboring data. Fixes foundry-rs#293
Yonkoo11
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse and
onbjerg
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dealwrote balances throughstdstorewithout packed mode. Tokens that store balance in a packed slot (e.g. post-upgrade USDC, Optimism sUSD) failfindor would clobber neighbor fields. Useenable_packed_slots()for balance writes indeal/dealERC1155/dealERC721.Linked issue
Fixes #293
Test plan
test_Deal*suite passestest_DealTokenPackedBalance(balance in low 128 bits; high bits preserved)AI assistance
Prepared with AI assistance; I reviewed and tested the change.
Risk
Packed mode is slightly more expensive on find. Unpacked ERC20s still work (covered by existing tests).