Skip to content

Add ADC decompression - #131

Merged
Schamper merged 5 commits into
fox-it:mainfrom
joost-j:feature/adc
Aug 5, 2026
Merged

Add ADC decompression#131
Schamper merged 5 commits into
fox-it:mainfrom
joost-j:feature/adc

Conversation

@joost-j

@joost-j joost-j commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Add support for ADC (Apple Data Compression) decompression. Though it is no longer commonly used, it is still a supported compression method in a DMG file.

Comment thread tests/compression/test_adc.py
@joost-j
joost-j requested a review from Schamper August 4, 2026 20:04
Comment thread dissect/util/compression/adc.py Outdated
@joost-j
joost-j requested a review from Schamper August 5, 2026 13:57
Comment thread dissect/util/compression/adc.py
joost-j and others added 2 commits August 5, 2026 18:51
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (fd59c1c) to head (968c946).

Files with missing lines Patch % Lines
dissect/util/compression/adc.py 0.00% 25 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #131   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         29      30    +1     
  Lines       2106    2131   +25     
=====================================
- Misses      2106    2131   +25     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 33 untouched benchmarks
🆕 2 new benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
🆕 test_benchmark_adc_decompress[basic] N/A 197.9 µs N/A
🆕 test_benchmark_adc_decompress[large] N/A 4.8 ms N/A

Comparing joost-j:feature/adc (968c946) with main (fd59c1c)

Open in CodSpeed

@Schamper
Schamper merged commit aadca22 into fox-it:main Aug 5, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants