Update build to Android SDK 33 (Android S)#108
Open
davidhubbard wants to merge 2 commits intofpvout:masterfrom
Open
Update build to Android SDK 33 (Android S)#108davidhubbard wants to merge 2 commits intofpvout:masterfrom
davidhubbard wants to merge 2 commits intofpvout:masterfrom
Conversation
This updates the code so it compiles cleanly under Android S, which amounts to adding android:exported="true" to AndroidManifest.xml and PendingIntent.FLAG_IMMUTABLE to PendingIntent.getBroadcast(flags = 0)
Member
|
Thanks for the PR, doesn't have time to test it, but it looks fine. I'm merging it :) |
jlucidar
approved these changes
Aug 8, 2024
Member
|
Seems I don't have write permissions on this repo anymore 🧐. Sorry. |
Author
Thanks for the approval nonetheless. Maybe someone with write access will come along, and if so, cool. I'm out flying with this so it's a win either way for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app builds just fine on newer SDKs. This makes the minor tweaks to keep the code building cleanly.
I understand commits usually go on the dev branch. Please let me know if you want this pull request to go to the dev branch instead.