fix: have overlay show correct png on onResume#94
Closed
mnbpdx wants to merge 1 commit intofpvout:masterfrom
Closed
fix: have overlay show correct png on onResume#94mnbpdx wants to merge 1 commit intofpvout:masterfrom
mnbpdx wants to merge 1 commit intofpvout:masterfrom
Conversation
Author
|
While we're at it, that block of code is basically identical in both onCreate() and onResume(), I can pull it into its own method if ya like. |
Member
|
Thanks @mnbpdx for your contribution ! |
Author
|
Ahh bummer, tried to search for it but must have missed it. And I will make any future PR's to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like when
onResume()was in a "disconnected" state, it was sendingOverlayStatus.ConnectedtoshowOverlay()rather thanOverlayStatus.Disconnected.Could be wrong about this, I'm decently new to Android/coding in general so please check my work. That being said, my test device was showing the "connected" PNG when disconnected, and this seemed to solve it.
In fact, my device always showed the "connected" PNG, I think because the "disconnected" PNG that was set up in
onCreate()was immediately being re-drawn byonResume().Before changes (on initial start up, fresh install):

After:
